linux-kernel - Re: [PATCH v2 08/12] nova-core: sequencer: Add register opcodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3c625930-348a-4c96-a63a-6a3e98e59734@nvidia.com>
Date: Wed, 5 Nov 2025 13:55:15 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Timur Tabi <ttabi@...dia.com>, Joel Fernandes <joelagnelf@...dia.com>
Cc: Alexandre Courbot <acourbot@...dia.com>,
 "lossin@...nel.org" <lossin@...nel.org>,
 "a.hindborg@...nel.org" <a.hindborg@...nel.org>,
 "boqun.feng@...il.com" <boqun.feng@...il.com>,
 "ojeda@...nel.org" <ojeda@...nel.org>, "simona@...ll.ch" <simona@...ll.ch>,
 "tmgross@...ch.edu" <tmgross@...ch.edu>,
 "alex.gaynor@...il.com" <alex.gaynor@...il.com>,
 "mripard@...nel.org" <mripard@...nel.org>,
 "joel@...lfernandes.org" <joel@...lfernandes.org>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
 "maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
 "nouveau@...ts.freedesktop.org" <nouveau@...ts.freedesktop.org>,
 "rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>,
 "dakr@...nel.org" <dakr@...nel.org>,
 "bjorn3_gh@...tonmail.com" <bjorn3_gh@...tonmail.com>,
 "tzimmermann@...e.de" <tzimmermann@...e.de>,
 "airlied@...il.com" <airlied@...il.com>,
 "aliceryhl@...gle.com" <aliceryhl@...gle.com>,
 "gary@...yguo.net" <gary@...yguo.net>, Alistair Popple <apopple@...dia.com>
Subject: Re: [PATCH v2 08/12] nova-core: sequencer: Add register opcodes

On 11/5/25 8:30 AM, Timur Tabi wrote:
> On Wed, 2025-11-05 at 03:45 +0000, Joel Fernandes wrote:
>>>> +        dev_dbg!(
>>>> +            sequencer.dev,
>>>> +            "RegWrite: addr=0x{:x}, val=0x{:x}\n",
>>>
>>> Hi Joel,
>>>
>>> The RegRead, RegWrite, RegPoll prints generate over 400 lines
>>> per GPU, into the logs. This is too much, especially now that
>>> it's been working for a while.
>>>
>>> I'm thinking let's delete these entirely. If we somehow get
>>> into debugging this aspect of the sequencer, we can temporarily
>>> add whatever printing we need, but I think it's one notch too
>>> far for the final product, now that you have it working.
>>
>> Sure John, I am Ok with removing the prints. I will do so for the next spin.
> 
> Or, you could do what Nouveau does, and define two more printk levels below DBG specifically for
> stuff like this:
> 
> #define nvdev_trace(d,f,a...) nvdev_printk((d), TRACE,   info, f, ##a)
> #define nvdev_spam(d,f,a...)  nvdev_printk((d),  SPAM,    dbg, f, ##a)

...and those are unusable, unfortunately. I've tried.

ftrace/bpftrace, maybe those are the real way to "trace"...or something
other than this.

thanks,
-- 
John Hubbard