linux-kernel - Re: [PATCH net v1 2/2] gve: use max allowed ring size for ZC page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa6ace55-fb4a-4275-bcd0-c733a788d2b9@kernel.org>
Date: Wed, 5 Nov 2025 22:58:09 +0100
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Mina Almasry <almasrymina@...gle.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Joshua Washington <joshwash@...gle.com>,
 Harshitha Ramamurthy <hramamurthy@...gle.com>,
 Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>,
 Simon Horman <horms@...nel.org>, Willem de Bruijn <willemb@...gle.com>,
 ziweixiao@...gle.com, Vedant Mathur <vedantmathur@...gle.com>
Subject: Re: [PATCH net v1 2/2] gve: use max allowed ring size for ZC
 page_pools

On 05/11/2025 21.07, Mina Almasry wrote:
> diff --git a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c
> index 0e2b703c673a..f63ffdd3b3ba 100644
> --- a/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c
> +++ b/drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c
> @@ -8,6 +8,8 @@
>   #include "gve.h"
>   #include "gve_utils.h"
>   
> +#include "net/netdev_queues.h"
> +

Shouldn't this be with "<net/netdev_queues.h>" ?

And why include this and not net/page_pool/types.h that you just
modified in previous patch?

>   int gve_buf_ref_cnt(struct gve_rx_buf_state_dqo *bs)
>   {
>   	return page_count(bs->page_info.page) - bs->page_info.pagecnt_bias;
> @@ -263,6 +265,8 @@ struct page_pool *gve_rx_create_page_pool(struct gve_priv *priv,
>   	if (priv->header_split_enabled) {
>   		pp.flags |= PP_FLAG_ALLOW_UNREADABLE_NETMEM;
>   		pp.queue_idx = rx->q_num;
> +		if  (netif_rxq_has_unreadable_mp(priv->dev, rx->q_num))
> +			pp.pool_size = PAGE_POOL_MAX_RING_SIZE;
>   	}
>