linux-kernel - Re: [PATCH v4 3/3] spmi: spmi-pmic-arb: add support for PMIC arbiter v8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202511251730.R2wx1j01-lkp@intel.com>
Date: Tue, 25 Nov 2025 19:45:02 +0800
From: kernel test robot <lkp@...el.com>
To: Jishnu Prakash <jishnu.prakash@....qualcomm.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	David Collins <david.collins@....qualcomm.com>,
	konrad.dybcio@....qualcomm.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	Jishnu Prakash <jishnu.prakash@....qualcomm.com>,
	kamal.wadhwa@....qualcomm.com, aiqun.yu@....qualcomm.com
Subject: Re: [PATCH v4 3/3] spmi: spmi-pmic-arb: add support for PMIC arbiter
 v8

Hi Jishnu,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 6a23ae0a96a600d1d12557add110e0bb6e32730c]

url:    https://github.com/intel-lab-lkp/linux/commits/Jishnu-Prakash/dt-bindings-spmi-split-out-common-QCOM-SPMI-PMIC-arbiter-properties/20251124-175115
base:   6a23ae0a96a600d1d12557add110e0bb6e32730c
patch link:    https://lore.kernel.org/r/20251124-pmic_arb_v8-v4-3-d91dcbf097c7%40oss.qualcomm.com
patch subject: [PATCH v4 3/3] spmi: spmi-pmic-arb: add support for PMIC arbiter v8
config: loongarch-randconfig-002-20251125 (https://download.01.org/0day-ci/archive/20251125/202511251730.R2wx1j01-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251125/202511251730.R2wx1j01-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511251730.R2wx1j01-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/spmi/spmi-pmic-arb.c: In function '_pmic_arb_init_apid_v7':
>> drivers/spmi/spmi-pmic-arb.c:1391:13: warning: unused variable 'ret' [-Wunused-variable]
    1391 |         int ret, i;
         |             ^~~


vim +/ret +1391 drivers/spmi/spmi-pmic-arb.c

  1386	
  1387	static int _pmic_arb_init_apid_v7(struct spmi_pmic_arb_bus *bus, int index,
  1388					  int max_buses, unsigned long periph_mask)
  1389	{
  1390		struct spmi_pmic_arb *pmic_arb = bus->pmic_arb;
> 1391		int ret, i;
  1392	
  1393		if (index < 0 || index >= max_buses) {
  1394			dev_err(&bus->spmic->dev, "Unsupported bus index %d detected\n",
  1395				index);
  1396			return -EINVAL;
  1397		}
  1398	
  1399		bus->base_apid = 0;
  1400		bus->apid_count = 0;
  1401		for (i = 0; i <= index; i++) {
  1402			bus->base_apid += bus->apid_count;
  1403			bus->apid_count = readl_relaxed(pmic_arb->core +
  1404							PMIC_ARB_FEATURES + i * 4) &
  1405							periph_mask;
  1406		}
  1407	
  1408		if (bus->apid_count == 0) {
  1409			dev_err(&bus->spmic->dev, "Bus %d not implemented\n", index);
  1410			return -EINVAL;
  1411		} else if (bus->base_apid + bus->apid_count > pmic_arb->max_periphs) {
  1412			dev_err(&bus->spmic->dev, "Unsupported max APID %d detected\n",
  1413				bus->base_apid + bus->apid_count);
  1414			return -EINVAL;
  1415		}
  1416	
  1417		return pmic_arb_init_apid_min_max(bus);
  1418	}
  1419	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki