lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <abec3933-279d-4111-8adf-a2e1280ce0b7@kernel.org>
Date: Fri, 19 Dec 2025 15:52:51 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Alexandru Gagniuc <mr.nuke.me@...il.com>, andersson@...nel.org,
 mathieu.poirier@...aro.org, krzk+dt@...nel.org, Rob Herring
 <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] dt-bindings: remoteproc: qcom,ipq8074-wcss-pil:
 convert to DT schema

On 19/12/2025 05:34, Alexandru Gagniuc wrote:
> Convert the QCS404 and IPQ WCSS Peripheral Image Loader bindings to DT
> schema. The text bindngs incorrectly implied that IPQ8074 needs only
> one qcom,smem-states entry. This is only true for QCS404. IPQ8074
> requires both "stop" and "shutdown".
> 
> The example is to be added in a subsequent commit that adds the
> IPQ9574 binding.
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@...il.com>

This is not v1, but v2. Look - what is this "dt-bindings: remoteproc:
qcom,ipq8074-wcss-pil: convert to DT schema" in my inbox?

And what is this:

> 
> ---
> Changes since RFC
>  - rename binding from ipq9574 to ipq8074
>  - use a real person instead of placeholder as maintainer
>  - drop redundant minItems and descriptions
>  - merge if: clauses as suggested by Krzysztof
>  - various other fixes suggested by Krzysztof

So not v1?

And now run b4 diff and find differences.

If this is anyhow weird (although how counting from 0 or -1 or -2 if you
have 3 RFCs can be natural?), then just use b4 which would solve all
these problems.

You also miss cover letter, which would be easily solved with b4.

You are not making it easier for reviewers.

> 
> I used my name as a placeholder for the "maintainer" field. Krzysztof
> mentioned to get the "SOC maintainer" using get_maintainer. I don't
> know how to do that, and I don't see anyone listed for QCS404,
> IPQ8074, or IPQ9574. The bindings apply to any of those SOCs.

So you run get_maintainer.pl script on the soc DTSI file and you got
zero results? I claim that's impossible... but just in case please post
here the commands.

Anyway listing yourself is fine.

Trying to see what happened here:
b4 diff '<20251219043425.888585-4-mr.nuke.me@...il.com>'
Grabbing thread from
lore.kernel.org/all/20251219043425.888585-4-mr.nuke.me@...il.com/t.mbox.gz
---
Analyzing 15 messages in the thread
Could not find lower series to compare against.

so this patch will wait.


Best regards,
Krzysztof

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ