linux-kernel - Re: [PATCH 1/3] dt-bindings: mmc: spacemit,sdhci: add reset support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251221-unnatural-resilient-trogon-7b20a7@quoll>
Date: Sun, 21 Dec 2025 16:09:37 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yixun Lan <dlan@...too.org>
Cc: Ulf Hansson <ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Paul Walmsley <pjw@...nel.org>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>, 
	Iker Pedrosa <ikerpedrosam@...il.com>, linux-mmc@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-riscv@...ts.infradead.org, spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: mmc: spacemit,sdhci: add reset support

On Sun, Dec 21, 2025 at 04:20:26PM +0800, Yixun Lan wrote:
> The SpacemiT SDHCI controller has two reset lines, one connect to AXI bus
> which shared by all controllers, while another one connect to individual
> controller separately.
> 
> Signed-off-by: Yixun Lan <dlan@...too.org>
> ---
>  Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml b/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> index 13d9382058fb..322c69b056f4 100644
> --- a/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/spacemit,sdhci.yaml
> @@ -32,12 +32,24 @@ properties:
>        - const: core
>        - const: io
>  
> +  resets:
> +    items:
> +      - description: axi reset, connect to AXI bus, shared by all controllers
> +      - description: sdh reset, connect to individual controller separately
> +
> +  reset-names:
> +    items:
> +      - const: axi
> +      - const: sdh
> +
>  required:
>    - compatible
>    - reg
>    - interrupts
>    - clocks
>    - clock-names
> +  - resets
> +  - reset-names

This is an ABI break without mentioning in commit msg and without any
justification.

Best regards,
Krzysztof