[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aUo9Uh2CxRvxxE2d@hu-arakshit-hyd.qualcomm.com>
Date: Tue, 23 Dec 2025 12:27:22 +0530
From: Abhinaba Rakshit <abhinaba.rakshit@....qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: monaco: add QCrypto node
On Mon, Dec 22, 2025 at 11:29:06AM +0200, Dmitry Baryshkov wrote:
> On Mon, Dec 22, 2025 at 01:00:19PM +0530, Abhinaba Rakshit wrote:
> > Add Qualcomm Crypto Engine device node for Monaco platform.
> > Bindings and Crypto DMA nodes for the same platform is already
> > present in the tree.
> >
> > QCE and Crypto DMA nodes patch was applied as part of the
> > commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"),
> > however was reverted due to compatible string being miss-matched
> > against schema.
> >
> > Resubmitting the enablement of QCE device node for monaco platform
> > with compatible-string being aligned with qcom-qce schema.
>
> This part will not make any sense in the commit message, once the
> patch gets applied.
>
> Please put it under the three dashes at the end of the commit message,
> after the SoB (or into the b4's cover letter, it will also be properly
> included here). Or, better, rephrase it in a way that makes sense for
> the applied patch.
Sure, will move this description to b4's cover-letter and update in patchset v2.
>
> >
> > Signed-off-by: Abhinaba Rakshit <abhinaba.rakshit@....qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/monaco.dtsi | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
>
> With the commit message fixed:
>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
>
Thank you
Abhinaba Rakshit
Powered by blists - more mailing lists