[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CADnq5_PnT9iMTvgzGCDVqVdkCO0Mcyr13VSz3Xqrgatgd5JuUg@mail.gmail.com>
Date: Tue, 20 Jan 2026 10:08:15 -0500
From: Alex Deucher <alexdeucher@...il.com>
To: Mukesh Ogare <mukeshogare871@...il.com>
Cc: christian.koenig@....com, alexander.deucher@....com, airlied@...il.com,
simona@...ll.ch, amd-gfx@...ts.freedesktop.org,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/radeon: convert VCE logging to drm_* helpers
Applied. Thanks!
On Tue, Jan 20, 2026 at 3:26 AM Mukesh Ogare <mukeshogare871@...il.com> wrote:
>
> Replace legacy DRM_INFO() logging in the VCE code with drm_info()
> helper that takes a struct drm_device.
>
> This provides proper device context in dmesg on multi-GPU systems and
> aligns the radeon driver with current DRM logging practices.
>
> Note that this change logs firmware version information at info level
> and does not indicate a failure.
>
> Signed-off-by: Mukesh Ogare <mukeshogare871@...il.com>
> ---
> drivers/gpu/drm/radeon/radeon_vce.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_vce.c b/drivers/gpu/drm/radeon/radeon_vce.c
> index bdbc1bbe8a9b..ed631c0e5e28 100644
> --- a/drivers/gpu/drm/radeon/radeon_vce.c
> +++ b/drivers/gpu/drm/radeon/radeon_vce.c
> @@ -121,8 +121,9 @@ int radeon_vce_init(struct radeon_device *rdev)
> if (sscanf(c, "%2u]", &rdev->vce.fb_version) != 1)
> return -EINVAL;
>
> - DRM_INFO("Found VCE firmware/feedback version %d.%d.%d / %d!\n",
> - start, mid, end, rdev->vce.fb_version);
> + drm_info(&rdev->ddev,
> + "Found VCE firmware/feedback version %d.%d.%d / %d!\n",
> + start, mid, end, rdev->vce.fb_version);
>
> rdev->vce.fw_version = (start << 24) | (mid << 16) | (end << 8);
>
> --
> 2.43.0
>
Powered by blists - more mailing lists