[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7a7405d8-c03f-4c04-94b0-87684fd92316@oss.qualcomm.com>
Date: Wed, 21 Jan 2026 17:01:18 +0800
From: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
To: Tarang Raval <tarang.raval@...iconsignals.io>
Cc: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH v4 1/2] media: i2c: imx412: fix sensor power-on timing
Hi Tarang,
On 1/21/2026 4:47 PM, Tarang Raval wrote:
> Hi Wenmeng,
>
>> Assert the reset GPIO before first power up. This avoids a mismatch where
>> the first power up (when the reset GPIO defaults deasserted) differs from
>> subsequent cycles.
>>
>> Signed-off-by: Wenmeng Liu <wenmeng.liu@....qualcomm.com>
>> ---
>> drivers/media/i2c/imx412.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/media/i2c/imx412.c b/drivers/media/i2c/imx412.c
>> index b3826f80354703b17b416dc233854da3f5736e38..5cb55deb125edb218779b076429f9fff93e11a08 100644
>> --- a/drivers/media/i2c/imx412.c
>> +++ b/drivers/media/i2c/imx412.c
>> @@ -1188,6 +1188,8 @@ static int imx412_probe(struct i2c_client *client)
>>
>> mutex_init(&imx412->mutex);
>>
>> + gpiod_set_value_cansleep(imx412->reset_gpio, 1);
>> +
>
> Just logic needs to be set to high when requesting this GPIO in
> imx412_parse_hw_config.
Thank you for pointing that out.
Thanks,
Wenmeng
Powered by blists - more mailing lists