linux-kernel - Re: request_irq() usage in wm8350_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbd0ffc0-d308-4064-893b-3c1b51a13a35@opensource.cirrus.com>
Date: Wed, 21 Jan 2026 11:22:32 +0000
From: Richard Fitzgerald <rf@...nsource.cirrus.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org
Cc: Lee Jones <lee@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: request_irq() usage in wm8350_register_irq().

On 21/01/2026 11:16 am, Sebastian Andrzej Siewior wrote:
> Hi,
> 
> I've been staring wm8350_register_irq(). It does
> 
> | request_threaded_irq(irq + wm8350->irq_base, NULL,
> | 		handler, flags, name, data);
> 
> and every single user passes 0 as flags. This means it asks for a
> threaded IRQ and does not pass IRQF_ONESHOT.
> 
> So either this is not working because it triggers the warnings
> 	Threaded irq requested with handler=NULL and !ONESHOT
> 
> followed by -EINVAL _or_ every single user of this driver sits in
> system where the irqchip is IRQCHIP_ONESHOT_SAFE marked.
> Which is it?
> 
> Sebastian

Or because request_threaded_irq() supplies a default handler, so
handler!=NULL when it calls __setup_irq().


int request_threaded_irq(unsigned int irq, irq_handler_t handler,
			 irq_handler_t thread_fn, unsigned long irqflags,
			 const char *devname, void *dev_id)
{

...

	if (!handler) {
		if (!thread_fn)
			return -EINVAL;
		handler = irq_default_primary_handler;
	}

...


	retval = __setup_irq(irq, desc, action);

...
}