linux-kernel - Re: [PATCH v5 29/31] clk: at91: at91sam9g45: switch to parent_data and parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70333077-3223-4f99-bfc9-cd3069a25d98@tuxon.dev>
Date: Sat, 31 Jan 2026 16:19:45 +0200
From: Claudiu Beznea <claudiu.beznea@...on.dev>
To: ryan.wanner@...rochip.com, mturquette@...libre.com, sboyd@...nel.org,
 nicolas.ferre@...rochip.com, alexandre.belloni@...tlin.com,
 bmasney@...hat.com, alexander.sverdlin@...il.com,
 varshini.rajendran@...rochip.com
Cc: cristian.birsan@...rochip.com, balamanikandan.gunasundar@...rochip.com,
 linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 29/31] clk: at91: at91sam9g45: switch to parent_data
 and parent_hw

Same here as in the previous patch.

On 1/16/26 22:07, ryan.wanner@...rochip.com wrote:
> From: Claudiu Beznea <claudiu.beznea@...on.dev>
> 
> Switch AT91SAM9G45 clocks to use parent_hw and parent_data. Having
> parent_data instead of parent names improves to clock registration
> speed and re-parenting.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@...on.dev>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@...rochip.com>
> ---
[ ...]

>   static void __init at91sam9g45_pmc_setup(struct device_node *np)
>   {
>   	const char *slck_name, *mainxtal_name;
> +	struct clk_parent_data parent_data[5];

Please mention in the patch description that you've also changed this while at 
it along with a reason.

Everything else LGTM.


>   	struct pmc_data *at91sam9g45_pmc;
> -	const char *parent_names[6];
> +	struct clk_hw *usbck_hw, *hw;
>   	struct regmap *regmap;
> -	struct clk_hw *hw;
>   	int i;
>   	bool bypass;
>