linux-kernel - [PATCH] soc: dove: pmu: Fix device node reference leaks in dove_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260131-dove_pmu-v1-1-1b40989778d1@gmail.com>
Date: Sat, 31 Jan 2026 22:21:08 +0800
From: Felix Gu <ustc.gu@...il.com>
To: Andrew Lunn <andrew@...n.ch>, 
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, 
 Gregory Clement <gregory.clement@...tlin.com>, 
 Russell King <rmk+kernel@....linux.org.uk>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 Felix Gu <ustc.gu@...il.com>
Subject: [PATCH] soc: dove: pmu: Fix device node reference leaks in
 dove_init_pmu()

Use __free(device_node) cleanup attribute for domains_node and add
missing of_node_put(np_pmu) calls in error paths to prevent device
node reference leaks.

Fixes: 44e259ac909f ("ARM: dove: create a proper PMU driver for power domains, PMU IRQs and resets")Y
Signed-off-by: Felix Gu <ustc.gu@...il.com>
---
 drivers/soc/dove/pmu.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/soc/dove/pmu.c b/drivers/soc/dove/pmu.c
index dd8ade8e9ee8..3b2567f20649 100644
--- a/drivers/soc/dove/pmu.c
+++ b/drivers/soc/dove/pmu.c
@@ -371,7 +371,7 @@ int __init dove_init_pmu_legacy(const struct dove_pmu_initdata *initdata)
  */
 int __init dove_init_pmu(void)
 {
-	struct device_node *np_pmu, *domains_node;
+	struct device_node *np_pmu;
 	struct pmu_data *pmu;
 	int ret, parent_irq;
 
@@ -380,15 +380,19 @@ int __init dove_init_pmu(void)
 	if (!np_pmu)
 		return 0;
 
-	domains_node = of_get_child_by_name(np_pmu, "domains");
+	struct device_node *domains_node __free(device_node) =
+		of_get_child_by_name(np_pmu, "domains");
 	if (!domains_node) {
 		pr_err("%pOFn: failed to find domains sub-node\n", np_pmu);
+		of_node_put(np_pmu);
 		return 0;
 	}
 
 	pmu = kzalloc(sizeof(*pmu), GFP_KERNEL);
-	if (!pmu)
+	if (!pmu) {
+		of_node_put(np_pmu);
 		return -ENOMEM;
+	}
 
 	spin_lock_init(&pmu->lock);
 	pmu->of_node = np_pmu;
@@ -399,6 +403,7 @@ int __init dove_init_pmu(void)
 		iounmap(pmu->pmu_base);
 		iounmap(pmu->pmc_base);
 		kfree(pmu);
+		of_node_put(np_pmu);
 		return -ENOMEM;
 	}
 

---
base-commit: 33a647c659ffa5bdb94abc345c8c86768ff96215
change-id: 20260131-dove_pmu-83fa64fb16ed

Best regards,
-- 
Felix Gu <ustc.gu@...il.com>