lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070410082049.GC16621@2ka.mipt.ru> Date: Tue, 10 Apr 2007 12:20:49 +0400 From: Evgeniy Polyakov <johnpol@....mipt.ru> To: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com> Cc: davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, jgarzik@...ox.com, cramerj@...el.com, auke-jan.h.kok@...el.com, christopher.leech@...el.com Subject: Re: [PATCH 2/2] NET: Multiqueue network device support implementation. On Mon, Apr 09, 2007 at 02:28:41PM -0700, Peter P Waskiewicz Jr (peter.p.waskiewicz.jr@...el.com) wrote: > + alloc_size = (sizeof(struct net_device_subqueue) * queue_count); > + > + p = kzalloc(alloc_size, GFP_KERNEL); > + if (!p) { > + printk(KERN_ERR "alloc_netdev: Unable to allocate queues.\n"); > + return NULL; I think you either do not want to print it, or want additional details about device... > + } > + > + dev->egress_subqueue = p; > + dev->egress_subqueue_count = queue_count; > + > dev->get_stats = maybe_internal_stats; > setup(dev); > strcpy(dev->name, name); > return dev; > } > -EXPORT_SYMBOL(alloc_netdev); > +EXPORT_SYMBOL(alloc_netdev_mq); > > /** > * free_netdev - free network device > @@ -3345,6 +3358,7 @@ void free_netdev(struct net_device *dev) > { > #ifdef CONFIG_SYSFS > /* Compatibility with error handling in drivers */ > + kfree((char *)dev->egress_subqueue); > if (dev->reg_state == NETREG_UNINITIALIZED) { > kfree((char *)dev - dev->padded); > return; > @@ -3356,6 +3370,7 @@ void free_netdev(struct net_device *dev) > /* will free via device release */ > put_device(&dev->dev); > #else > + kfree((char *)dev->egress_subqueue); Still casting :) -- Evgeniy Polyakov - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists