lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <E1HbE8w-0000LY-00@gondolin.me.apana.org.au> Date: Tue, 10 Apr 2007 21:04:10 +1000 From: Herbert Xu <herbert@...dor.apana.org.au> To: peter.p.waskiewicz.jr@...el.com (Waskiewicz Jr, Peter P) Cc: jengelh@...ux01.gwdg.de, davem@...emloft.net, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, jgarzik@...ox.com, cramerj@...el.com, auke-jan.h.kok@...el.com, christopher.leech@...el.com Subject: Re: [PATCH 2/2] NET: Multiqueue network device support implementation. Waskiewicz Jr, Peter P <peter.p.waskiewicz.jr@...el.com> wrote: > >> >@@ -3356,6 +3370,7 @@ void free_netdev(struct net_device *dev) >> > /* will free via device release */ >> > put_device(&dev->dev); >> > #else >> >+ kfree((char *)dev->egress_subqueue); >> > kfree((char *)dev - dev->padded); >> > #endif >> > } >> >> Ahem. Explain that cast. > > This can be removed if needed; however, I'm just copying what > the other kfree()'s are doing in this function. Any instance of a > typecast that I introduced in these patches are just following what > others have done in that section of the code. So the cast is just for > consistency in this particular area. If you'd like me to remove it, I > can do that. The other cast is there for the subtraction, not the kfree... Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists