netdev - Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071104.202454.216339392.davem@davemloft.net>
Date:	Sun, 04 Nov 2007 20:24:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	ak@...e.de
Cc:	dada1@...mosbay.com, netdev@...r.kernel.org, acme@...hat.com,
	jarkao2@...pl
Subject: Re: [PATCH] INET : removes per bucket rwlock in tcp/dccp ehash
 table

From: Andi Kleen <ak@...e.de>
Date: Mon, 5 Nov 2007 00:01:03 +0100

> On Sunday 04 November 2007 22:56:21 David Miller wrote:
> > From: Andi Kleen <ak@...e.de>
> 
> > This makes a huge different as we have to set NR_CPUS to 4096
> > in order to handle the cpu numbering of some UltraSPARC-IV
> > machines.
> 
> Really? Hopefully you have a large enough stack then. There 
> are various users who put char str[NR_CPUS] on the stack
> and a few other data structures also get incredibly big with
> NR_CPUS arrays.

For the stack case there is one debugging case, and that's for
sprintf'ing cpusets.  That could be easily eliminated.

> If it's for sparse cpu ids -- x86 handles those with an 
> translation array.

I would rather not do this, so much assembler code indexes straight
into the per-cpu arrays.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html