netdev - Re: [PATCH] OOPS with NETLINK_FIB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <476B89D8.2060602@sw.ru>
Date:	Fri, 21 Dec 2007 12:39:36 +0300
From:	"Denis V. Lunev" <den@...ru>
To:	David Miller <davem@...emloft.net>
CC:	den@...nvz.org, devel@...nvz.org, netdev@...r.kernel.org,
	kaber@...sh.net, kuznet@....inr.ac.ru
Subject: Re: [PATCH] OOPS with NETLINK_FIB_LOOKUP netlink socket

David Miller wrote:
> From: "Denis V. Lunev" <den@...nvz.org>
> Date: Fri, 21 Dec 2007 12:00:43 +0300
> 
>> nl_fib_input re-reuses incoming skb to send the reply. This means that this
>> packet will be freed twice, namely in:
>> - netlink_unicast_kernel
>> - on receive path
>> Use clone to send as a cure, the caller is responsible for kfree_skb on error.
>>
>> Thanks to Alexey Dobryan, who originally found the problem.
>>
>> Signed-off-by: Denis V. Lunev <den@...nvz.org>
> 
> What introduced this bug?  This code didn't have this
> problem previously.
> 

commit cd40b7d3983c708aabe3d3008ec64ffce56d33b0
Author: Denis V. Lunev <den@...nvz.org>
Date:   Wed Oct 10 21:15:29 2007 -0700
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html