netdev - Re: [PATCH] [IPV4]: Update MTU to all related cache entries in ip_rt_frag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080426.232756.259679168.davem@davemloft.net>
Date:	Sat, 26 Apr 2008 23:27:56 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	timo.teras@....fi
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [IPV4]: Update MTU to all related cache entries in
 ip_rt_frag_needed()

From: Timo_Teräs <timo.teras@....fi>
Date: Thu, 24 Apr 2008 13:05:27 +0300

> Add struct net_device parameter to ip_rt_frag_needed() and update MTU to
> cache entries where ifindex is specified. This is similar to what is
> already done in ip_rt_redirect().
> 
> Signed-off-by: Timo Teras <timo.teras@....fi>
> ---
> I noticed this bug when using GRE tunnel bound to specific device. This
> causes ip_gre to use ifindex in ip_route_output_key() lookups and the
> results are not proper unless the MTU is updated for entries where
> ifindex is specified (causing my tunneled packets to be dropped).
> 
> I have a patch for older kernels too if this is good for -stable.

I haven't forgotten about this patch, I'm just still thinking about
possible negative side effects.  I don't think there are any, but
I want to be sure.

This function has been a constant source of consternation.  It also
doesn't do the right thing when the TOS is modified mid-network, and
that's arguably wrong too but more difficult to solve efficiently than
this ifindex keying case.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html