netdev - Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080825.140522.192264181.davem@davemloft.net>
Date:	Mon, 25 Aug 2008 14:05:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ron.mercer@...gic.com
Cc:	jeff@...zik.org, Linux-Driver@...gic.com, netdev@...r.kernel.org
Subject: Re: [RFC] New Qlogic 10Gb Ethernet driver for 2.6.28

From: Ron Mercer <ron.mercer@...gic.com>
Date: Mon, 25 Aug 2008 10:01:48 -0700

> I see your point.  I will add the re-alignment but would like to jump
> over it for platforms that don't need it.  Is there a list somewhere of
> the RISC platforms that take a trap on unaligned accesses?  Or better
> yet, a list of those that don't?

If you're only doing this for the header portion it's not so
much of a cost.  For sizable packets you're using page
references, and you don't have to copy those, such copies
of the headers will also warm up the CPU cache as a nice
side effect.

Furthermore you stated that the alignment restriction only
is necessary for early revisions of the hardware.

Please, I do not want to give you a list of platform names
to ifdef up your driver with, that's messy.  Just make the
copy when necessary to align things properly.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html