[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090814.001322.146991956.davem@davemloft.net>
Date: Fri, 14 Aug 2009 00:13:22 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: oliver@...tkopp.net
Cc: urs@...ogud.escape.de, l.fu@...gutronix.de,
m.olbrich@...gutronix.de, netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6] can: Use WARN_ONCE() instead of BUG_ON() for
sanity check in receive path
From: Oliver Hartkopp <oliver@...tkopp.net>
Date: Fri, 14 Aug 2009 07:57:02 +0200
> David Miller wrote:
>> From: Oliver Hartkopp <oliver@...tkopp.net>
>> Date: Mon, 10 Aug 2009 13:27:09 +0200
>>
>>> Additionally it changes the return values to the common NET_RX_xxx constants.
>>
>> Don't munge unrelated changes together like this, split it up.
>>
>> Also, this is not net-2.6 material, I will only apply these changes
>> to net-next-2.6 at this point.
>
> No problem.
>
> Btw. this patch was removed from patchwork and i was not able to find it in
> your latest net-next-2.6 push this morning.
It's not in net-next-2.6 because I didn't apply it, which is pretty
clealy implied when I'm asking you to split the change up into
multiple patches.
When I ask for changes, I mark the patch in patchwork with the
"changes requested" state and expect you to send me new updated stuff.
You can look for patches in various "done" states by simply modifying
the "Filters" setting in the patch list.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists