netdev - Re: [PATCH 1/3] Revert Backoff [v3]: Rename skb to icmp_skb in tcp_v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090831.063435.190660445.davem@davemloft.net>
Date:	Mon, 31 Aug 2009 06:34:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ilpo.jarvinen@...sinki.fi
Cc:	damian@....rwth-aachen.de, netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] Revert Backoff [v3]: Rename skb to icmp_skb in
 tcp_v4_err()

From: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Date: Mon, 31 Aug 2009 16:22:58 +0300 (EEST)

> Not that related to the purpose of this patch but still worth to
> mention now that we are in the context... ...I wonder if this should
> be pskb_may_pull instead of direct compare here regardless of this
> change?

ICMP layer that invokes this code makes sure enough headers
are in the linear area already.

> Acked-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>

Thanks for reviewing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html