lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 02 Sep 2009 23:22:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	aabdulla@...dia.com
Cc:	manfred@...orfullife.com, akpm@...l.org, netdev@...r.kernel.org
Subject: Re: [PATCH] forcedeth: updated phy errata

From: Ayaz Abdulla <aabdulla@...dia.com>
Date: Mon, 31 Aug 2009 19:08:37 -0400

> This patch updates the special programming (and/or errata) needed in
> order to setup the phy for various vendor models.
> 
> The new models include:
> Marvell E1116
> Marvell E1111
> Marvell E1011
> Marvell E3016
> Broadcom 9507
> Broadcom AC131
> Broadcom 50610
> 
> Signed-off-by: Ayaz Abdulla <aabdulla@...dia.com>

Please document what these individual bits mean which you
are clearing, by using an individual define for each register
bit to describe it's purpose, and then define the mask as
a concatenation of these bits.

Having an opaque bitmask is not how to do this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists