netdev - Re: [PATCH] atm: dereference of he_dev->rbps_virt in he_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090902.232548.238393942.davem@davemloft.net>
Date:	Wed, 02 Sep 2009 23:25:48 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	roel.kluin@...il.com
Cc:	chas@....nrl.navy.mil, linux-atm-general@...ts.sourceforge.net,
	netdev@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] atm: dereference of he_dev->rbps_virt in
 he_init_group()

From: Roel Kluin <roel.kluin@...il.com>
Date: Sat, 29 Aug 2009 20:59:04 +0200

> he_dev->rbps_virt or he_dev->rbpl_virt allocation may fail.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> There was another in the same function.

These new return statements will both leak resources allocated
earlier.

All the caller is going to do is return -ENOMEM as well and
it does not cleanup actions at all.

Please fix this up.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html