netdev - Re: [PATCH] gianfar: Use pr_<level>, netdev_<level> and netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110616.233542.1974667912524600949.davem@davemloft.net>
Date:	Thu, 16 Jun 2011 23:35:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	linux-kernel@...r.kernel.org, sebastian.belden@...glemail.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] gianfar: Use pr_<level>, netdev_<level> and
 netif_<level>

From: Joe Perches <joe@...ches.com>
Date: Tue, 14 Jun 2011 11:57:47 -0700

> Use the current logging styles.
> 
> Add #define DEBUG to get same output for <foo>_dbg messages.
> Convert a few bare printks to pr_err.
> 
> Fix a likely copy/paste defect where a test was done with RX values:
>         if (num_rx_qs > MAX_RX_QS) {
> but TX limits were emitted:
>         printk(KERN_ERR "num_rx_qs(=%d) greater than MAX_RX_QS(=%d)\n",
>                               num_tx_qs, MAX_TX_QS);
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied, thanks Joe.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html