netdev - Re: [PATCH net-next-2.6] net: rfs: enable RFS before first data packet is received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110616.233841.1893411919443027926.davem@davemloft.net>
Date:	Thu, 16 Jun 2011 23:38:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	eric.dumazet@...il.com, therbert@...gle.com,
	netdev@...r.kernel.org, hadi@...erus.ca
Subject: Re: [PATCH net-next-2.6] net: rfs: enable RFS before first data
 packet is received

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Fri, 17 Jun 2011 00:50:46 +0100

> On Wed, 2011-06-15 at 04:15 +0200, Eric Dumazet wrote:
>> @@ -1594,6 +1594,7 @@ int tcp_v4_do_rcv(struct sock *sk, struct sk_buff *skb)
>>  			goto discard;
>>  
>>  		if (nsk != sk) {
>> +			sock_rps_save_rxhash(nsk, skb->rxhash);
>>  			if (tcp_child_process(sk, nsk, skb)) {
>>  				rsk = nsk;
>>  				goto reset;
>> 
> 
> I haven't tried this, but it looks reasonable to me.
> 
> What about IPv6?  The logic in tcp_v6_do_rcv() looks very similar.

Indeed ipv6 side needs the same fix.

Eric please add that part and resubmit.  And in fact I might stick
this into net-2.6 instead of net-next-2.6

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html