netdev - Re: [PATCH] htb: improved accuracy at high rates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1350728976.13333.544.camel@edumazet-glaptop>
Date:	Sat, 20 Oct 2012 12:29:36 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Vimalkumar <j.vimal@...il.com>
Cc:	davem@...emloft.net, Jamal Hadi Salim <jhs@...atatu.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] htb: improved accuracy at high rates

On Fri, 2012-10-19 at 15:26 -0700, Vimalkumar wrote:

> +	if (likely(next_event > q->now)) {
> +		if (!test_bit(__QDISC_STATE_DEACTIVATED,
> +			      &qdisc_root_sleeping(q->watchdog.qdisc)->state)) {
> +			ktime_t time = ktime_set(0, 0);
> +			qdisc_throttled(q->watchdog.qdisc);
> +			time = ktime_add_ns(time, next_event);
> +			hrtimer_start(&q->watchdog.timer, time,
> +				      HRTIMER_MODE_ABS);
> +		}
> +	} else 


could use ns_to_ktime() helper

+	if (likely(next_event > q->now)) {
> +		if (!test_bit(__QDISC_STATE_DEACTIVATED,
> +			      &qdisc_root_sleeping(q->watchdog.qdisc)->state)) {
> +			qdisc_throttled(q->watchdog.qdisc);
> +			hrtimer_start(&q->watchdog.timer, ns_to_ktime(next_event),
> +				      HRTIMER_MODE_ABS);
> +		}
> +	} else 

I'll post a patch to cleanup net/sched/sch_api.c & net/sched/sch_cbq.c



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html