[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1360682002.13993.3.camel@edumazet-glaptop>
Date: Tue, 12 Feb 2013 07:13:22 -0800
From: Eric Dumazet <eric.dumazet@...il.com>
To: Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/2] tcp: fix FIN_WAIT2 timer expression in /proc/net/tcp
On Tue, 2013-02-12 at 06:57 -0800, Eric Dumazet wrote:
> I find this patch confusing :
>
> 1) Please don't change the indentation for a bug fix
>
> 2) You add a new 'active=3' field, that some user space
> reading /proc/net/tcp wont expect.
>
> So the changelog is not matching the changes.
Also, net/ipv4/inet_diag.c was not changed
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists