netdev - RE: [PATCH] net/phy: micrel: Add OF configuration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9848F2DB572E5649BA045B288BE08FBE015E4111@039-SN2MPN1-023.039d.mgd.msft.net>
Date:	Thu, 1 Aug 2013 06:52:22 +0000
From:	Duan Fugang-B38611 <B38611@...escale.com>
To:	Sean Cross <xobs@...agi.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	Steven Rostedt <rostedt@...dmis.org>
Subject: RE: [PATCH] net/phy: micrel: Add OF configuration support

On Thursday, August 1, 2013 at 2:23 PM, Sean Cross wrote:
>> When re-set rx/tx clock delay, rx/tx control delay, it is better to do dummy read the extended MII_KSZPHY_CLK_CONTROL_PAD_SKEW register one time.
> Can you please explain this?  I don't see anything in the datasheet I'm looking at (ksz9021rl) describing dummy reads.
> If both tx and rx skew are adjusted, should there be >two dummy reads or just one? 

When freescale engineers do the phy bring up, they add the dummy read. Pls refer the the patchwork: http://patchwork.ozlabs.org/patch/246616/
From ksz9021r1, there have no such condition. After I remove the dummy read, the imx6q sabrelite platform ethernet Gbps mode work fine.
For at91 micrel phy fixup, there have no dummy read: http://lists.infradead.org/pipermail/linux-arm-kernel/2013-July/183626.html
So, it just one confuse, and the dummy read is unnecessary.