netdev - [ebtables PATCH (resent)] arptables: long option "--set-counters" were missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140228123113.2220.55978.stgit@localhost>
Date:	Fri, 28 Feb 2014 13:32:27 +0100
From:	Jesper Dangaard Brouer <brouer@...hat.com>
To:	Bart De Schuymer <bdschuym@...dora.be>
Cc:	netdev@...r.kernel.org
Subject: [ebtables PATCH (resent)] arptables: long option "--set-counters"
 were missing

The long option "--set-counters" where missing in option parsing.
And the corresponding short option "-c" were not mentioned in
the help usage text.

Also update the arptables man page with a description
of the parameter.

Signed-off-by: Jesper Dangaard Brouer <brouer@...hat.com>
---
Resending patch... didn't get any response from Bart De Schuymer last time...

 userspace/arptables/arptables.8 |    8 ++++++++
 userspace/arptables/arptables.c |    3 ++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/userspace/arptables/arptables.8 b/userspace/arptables/arptables.8
index 0b6b62e..78b2c60 100644
--- a/userspace/arptables/arptables.8
+++ b/userspace/arptables/arptables.8
@@ -215,6 +215,14 @@ The target of the rule. This is one of the following values:
 a target extension (see
 .BR "TARGET EXTENSIONS" ")"
 or a user-defined chain name.
+.TP
+.BI "-c, --set-counters " "PKTS BYTES"
+This enables the administrator to initialize the packet and byte
+counters of a rule (during
+.B INSERT,
+.B APPEND,
+.B REPLACE
+operations).
 
 .SS RULE-SPECIFICATIONS
 The following command line arguments make up a rule specification (as used 
diff --git a/userspace/arptables/arptables.c b/userspace/arptables/arptables.c
index 4da6fea..3fb8ed5 100644
--- a/userspace/arptables/arptables.c
+++ b/userspace/arptables/arptables.c
@@ -152,6 +152,7 @@ static struct option original_opts[] = {
 	{ "help", 2, 0, 'h' },
 	{ "line-numbers", 0, 0, '0' },
 	{ "modprobe", 1, 0, 'M' },
+	{ "set-counters", 1, 0, 'c' },
 	{ 0 }
 };
 
@@ -529,7 +530,7 @@ exit_printhelp(void)
 "  --line-numbers		print line numbers when listing\n"
 "  --exact	-x		expand numbers (display exact values)\n"
 "  --modprobe=<command>		try to insert modules using this command\n"
-"  --set-counters PKTS BYTES	set the counter during insert/append\n"
+"  --set-counters -c PKTS BYTES	set the counter during insert/append\n"
 "[!] --version	-V		print package version.\n");
 	printf(" opcode strings: \n");
         for (i = 0; i < NUMOPCODES; i++)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html