netdev - Re: [PATCH] packet: fix potential use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1397142418.16584.28.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 10 Apr 2014 08:06:58 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Daniel Borkmann <dborkman@...hat.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>, Xi Wang <xii@...gle.com>
Subject: Re: [PATCH] packet: fix potential use after free

On Thu, 2014-04-10 at 10:19 +0200, Daniel Borkmann wrote:
> On 04/10/2014 03:22 AM, Eric Dumazet wrote:
> > From: Eric Dumazet <edumazet@...gle.com>
> >
> > As soon skb is queued into sk_receive_queue, it can be consumed,
> > so its racy to access skb->len.
> >
> > Given that sk_data_ready() / sock_def_readable() don't really care, just
> > use 0 instead of skb->len
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> > Cc: Xi Wang <xii@...gle.com>
> 
> Acked-by: Daniel Borkmann <dborkman@...hat.com>
> 
> Seems to be there since pre 2005 ...

Yeah, and many other places have the same error, a full audit is
probably needed.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html