netdev - Re: [PATCHv3 5/5] net: rfkill: gpio: hard-code the gpio names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbuvyEQVFv07Bq3dAeGEZr-MuJKJ5mYqdzicROJLwvHDw@mail.gmail.com>
Date:	Thu, 10 Apr 2014 18:27:47 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Chen-Yu Tsai <wens@...e.org>,
	Rhyland Klein <rklein@...dia.com>,
	Marc Dietrich <marvin24@....de>,
	Stephen Warren <swarren@...dotorg.org>,
	Arnd Bergmann <arnd@...db.de>,
	Alexandre Courbot <gnurou@...il.com>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCHv3 5/5] net: rfkill: gpio: hard-code the gpio names

On Tue, Apr 1, 2014 at 4:02 PM, Heikki Krogerus
<heikki.krogerus@...ux.intel.com> wrote:

> There is no need to dynamically generate the names. This
> will fix a static checker warning..
>
> net/rfkill/rfkill-gpio.c:144 rfkill_gpio_probe()
>     warn: variable dereferenced before check 'rfkill->name'
>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

Excellent,
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html