netdev - Re: ax88796 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1398131999.3624.167.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 22 Apr 2014 02:59:59 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Alexander Varnin <fenixk19@...l.ru>
Cc:	netdev@...r.kernel.org, Ben Dooks <ben.dooks@...ethink.co.uk>
Subject: Re: ax88796 driver

On Thu, 2014-04-17 at 03:42 +0400, Alexander Varnin wrote:
> Hello!
> 
> I am currently working on kernel and dealing with ax88796 driver, that
> has been written by Ben Dooks <ben@...tec.co.uk>. Since his address is
> not available anymore (says "Ben doesn't work here any more"), I want
> to ask help from somebody, who maybe somehow related to this driver.

I'm cc'ing Ben, but I doubt he'll want to remember this driver.

Ben.

> I want to ask on source code, because there is some non-obvious lines.
> 
> Take a look on ax_initial_check function from ax88796.c please [1].
> 
> Here is lines 127-129 of it:
> 
> ei_outb (E8390_NODMA + E8390_PAGE1 + E8390_STOP, ioaddr + E8390_CMD);
> regd = ei_inb (ioaddr + 0x0d);
> ei_outb (0xff, ioaddr + 0x0d);
> 
> This is supposed to be read and write to 0xD register on PAGE 1 of
> AX88796. But that offset stands for "Multicast Address Register 5
> ( MAR5 )" in AX88796 datasheet [2].
> 
> What is the point of doing so? That looks very like a mistake. If it
> is a mistake, I could make and send patch to fix it. But, please,
> explain why is it done?
> 
> 
> [1] http://lxr.free-electrons.com/source/drivers/net/ethernet/8390/ax88796.c#L116
> [2] http://www.digchip.com/datasheets/parts/datasheet/562/AX88796-pdf.php


-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)