netdev - Re: [PATCH] ethtool: return non-zero from do_sset() when any of ETHTOOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1428198948.11260.133.camel@decadent.org.uk>
Date:	Sun, 05 Apr 2015 02:55:48 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Ivan Vecera <ivecera@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ethtool: return non-zero from do_sset() when any of
 ETHTOOL_{G,S}* fails

On Fri, 2015-02-06 at 16:24 +0100, Ivan Vecera wrote:
> Function do_sset returns unconditionally zero error code without regard
> to return value of ETHTOOL_{G,S}* ioctls.
[...]

This behaviour is stupid, but it's what ethtool has always done and what
some scripts will depend on now.  If you can think of a simple way for
scripts to opt-in to sensible exit codes, please submit that.

Also, negative exit codes aren't sensible; please just use 0 and 1.

Ben.

-- 
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)