netdev - Re: [PATCH ethtool 4/5] ethtool: Prettify RX flow hash indirection table print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1428199259.11260.137.camel@decadent.org.uk>
Date:	Sun, 05 Apr 2015 03:00:59 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Amir Vadai <amirv@...lanox.com>
Cc:	netdev@...r.kernel.org, Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Saeed Mahameed <saeedm@...lanox.com>,
	Eyal Perry <eyalpe@...lanox.com>
Subject: Re: [PATCH ethtool 4/5] ethtool: Prettify RX flow hash indirection
 table print

On Sun, 2015-01-25 at 15:51 +0200, Amir Vadai wrote:
> From: Eyal Perry <eyalpe@...lanox.com>
> 
> When indirection table size is not a multiple of 8, a new line is
> missing at the last row of the table.

Yes, good point.

> In addition, make a distinction between the attribute name and its value
> by adding an indentation on the beginning of each line which contains
> values.

We've never consistently indented like that, so I don't see the point in
changing the output of just this one sub-command.

I'll just fix the first thing.

Ben.

-- 
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)