lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <56A80725.1070808@gmail.com> Date: Tue, 26 Jan 2016 15:54:13 -0800 From: Florian Fainelli <f.fainelli@...il.com> To: Andrew Lunn <andrew@...n.ch>, Olof Johansson <olof@...om.net> CC: Aaro Koskinen <aaro.koskinen@...ia.com>, "David S. Miller" <davem@...emloft.net>, Network Development <netdev@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org> Subject: Re: [BISECTED] v4.5-rc1 phylib regression On 26/01/16 14:09, Andrew Lunn wrote: >>> Nope, not an option. Only a small number of DTB actually use c22 or >>> c45. The majority of devices have no compatible at all. Why should >>> they, the binding documentation says it is optional! >> >> So one thing that can be done is to just have a whitelist in the >> driver that we add the known phy compatibles to, with a nice comment >> above that this should only be for legacy device trees. > > So you mean drivers/of/of_mdio.c:of_mdiobus_child_is_phy() > has a white list like: > > "brcm,40nm-ephy" > "marvell,88E1111", > "marvell,88e1116", > "marvell,88e1118", > "marvell,88e1149r", > "marvell,88e1310", > "marvell,88E1510", > "marvell,88E1514", > "moxa,moxart-rtl8201cp", > > Yes, that would work. > > We should also update the binding documentation to limit what is legal > in the compatible string. Agreed, and while at it, take the opportunity to make the compatible string clause 22/45 mandatory properties so we do not multiply the whitelist. Thanks! -- Florian
Powered by blists - more mailing lists