netdev - Re: [PATCH v3 net-next 5/7] sctp: prepare for socket backlog behavior change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160429220147.GA6672@localhost.localdomain>
Date:	Fri, 29 Apr 2016 19:01:47 -0300
From:	Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:	Eric Dumazet <edumazet@...gle.com>
Cc:	"David S . Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Soheil Hassas Yeganeh <soheil@...gle.com>,
	Alexei Starovoitov <ast@...com>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v3 net-next 5/7] sctp: prepare for socket backlog
 behavior change

On Fri, Apr 29, 2016 at 02:16:51PM -0700, Eric Dumazet wrote:
> sctp_inq_push() will soon be called without BH being blocked
> when generic socket code flushes the socket backlog.
> 
> It is very possible SCTP can be converted to not rely on BH,
> but this needs to be done by SCTP experts.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Thanks

> ---
>  net/sctp/inqueue.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/sctp/inqueue.c b/net/sctp/inqueue.c
> index b335ffcef0b9..9d87bba0ff1d 100644
> --- a/net/sctp/inqueue.c
> +++ b/net/sctp/inqueue.c
> @@ -89,10 +89,12 @@ void sctp_inq_push(struct sctp_inq *q, struct sctp_chunk *chunk)
>  	 * Eventually, we should clean up inqueue to not rely
>  	 * on the BH related data structures.
>  	 */
> +	local_bh_disable();
>  	list_add_tail(&chunk->list, &q->in_chunk_list);
>  	if (chunk->asoc)
>  		chunk->asoc->stats.ipackets++;
>  	q->immediate.func(&q->immediate);
> +	local_bh_enable();
>  }
>  
>  /* Peek at the next chunk on the inqeue. */
> -- 
> 2.8.0.rc3.226.g39d4020
>