netdev - RE: [PATCH] Add support for configuring Infiniband GUIDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB5PR05MB1848F2481D0767935CA14399C5700@DB5PR05MB1848.eurprd05.prod.outlook.com>
Date:	Mon, 9 May 2016 15:52:02 +0000
From:	Eli Cohen <eli@...lanox.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	"shemminger@...l.org" <shemminger@...l.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Eli Cohen (eli@....mellanox.co.il)" <eli@....mellanox.co.il>
Subject: RE: [PATCH] Add support for configuring Infiniband GUIDs

Hi Stephen,

ibstat is usually used with MLNX_OFED distributions and I don't think it is a part of libibverbs.
Moreover, in a previous patch I sent https://patchwork.ozlabs.org/patch/596492/ I documented in the change log the same format I mention in this patch. So if I change the format here we will have the changelog in the kernel tree invalid.

How do you think this should be addressed?

-----Original Message-----
From: Stephen Hemminger [mailto:stephen@...workplumber.org] 
Sent: Friday, May 06, 2016 1:54 PM
To: Eli Cohen <eli@...lanox.com>
Cc: shemminger@...l.org; netdev@...r.kernel.org
Subject: Re: [PATCH] Add support for configuring Infiniband GUIDs

On Fri,  6 May 2016 10:43:25 -0500
Eli Cohen <eli@...lanox.com> wrote:

> Add two NLA's that allow configuration of Infiniband node or port 
> GUIDs by referencing the IPoIB net device set over then physical 
> function. The format to be used is as follows:
> 
> ip link set dev ib0 vf 0 node_guid 00:02:c9:03:00:21:6e:70 ip link set 
> dev ib0 vf 0 port_guid 00:02:c9:03:00:21:6e:78
> 
> Issue: 702759
> Change-Id: I5ffb54d6de7bfa8650bf5818f484279914991d6e
> Signed-off-by: Eli Cohen <eli@...lanox.com>

I am not that familiar with Infiniband, but the documentation seems to use a non-colon form:
 # ip link set dev ib0 vf 0 node_guid 0002c90300216e70

Seems like ip should follow the lead of ibstat and friends.