netdev - Re: [PATCH] net/unix: drop obsolete fd-recursion limits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170717.085821.179430433629233314.davem@davemloft.net>
Date:   Mon, 17 Jul 2017 08:58:21 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dh.herrmann@...il.com
Cc:     netdev@...r.kernel.org, teg@...m.no, eric.dumazet@...il.com,
        hannes@...essinduktion.org, linux-kernel@...r.kernel.org,
        alban.crequy@...labora.co.uk, simon.mcvittie@...labora.co.uk
Subject: Re: [PATCH] net/unix: drop obsolete fd-recursion limits

From: David Herrmann <dh.herrmann@...il.com>
Date: Mon, 17 Jul 2017 11:35:54 +0200

 ...
> With all of this in mind, lets drop the recursion limit. It has no
> additional security value, anymore. On the contrary, it randomly
> confuses message brokers that try to forward file-descriptors, since
> any sendmsg(2) call can fail spuriously with ETOOMANYREFS if a client
> maliciously modifies the FD while inflight.
> 
> Cc: Alban Crequy <alban.crequy@...labora.co.uk>
> Cc: Simon McVittie <simon.mcvittie@...labora.co.uk>
> Signed-off-by: David Herrmann <dh.herrmann@...il.com>

Applied, thanks.