netdev - Re: [PATCH] mlx5: Remove call to ida_pre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180320152004.GA12959@bombadil.infradead.org>
Date:   Tue, 20 Mar 2018 08:20:04 -0700
From:   Matthew Wilcox <willy@...radead.org>
To:     David Miller <davem@...emloft.net>
Cc:     maorg@...lanox.com, saeedm@...lanox.com, matanb@...lanox.com,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org, leon@...nel.org
Subject: Re: [PATCH] mlx5: Remove call to ida_pre_get

On Tue, Mar 20, 2018 at 10:46:20AM -0400, David Miller wrote:
> From: Maor Gottlieb <maorg@...lanox.com>
> Date: Tue, 20 Mar 2018 14:41:49 +0200
> 
> > Saeed, Matan and I okay with this fix as well, it looks like it
> > shouldn't impact on the insertion rate.
> 
> I've applied this to net-next, thanks everyone.

Thanks, Dave.

I realised why this made sense when it was originally written.  Before
December 2016 (commit 7ad3d4d85c7a), ida_pre_get used to allocate one
bitmap per ida.  I moved it to a percpu variable, and at that point this
stopped making sense.