netdev - Re: [PATCH] brcmfmac: Use standard SKB list accessors in brcmf_sdiod_sglist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9667eb4f-36a1-0439-867b-1defc5946bc2@broadcom.com>
Date:   Wed, 14 Nov 2018 09:39:30 +0100
From:   Arend van Spriel <arend.vanspriel@...adcom.com>
To:     Andy Duan <fugang.duan@....com>,
        David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: [PATCH] brcmfmac: Use standard SKB list accessors in
 brcmf_sdiod_sglist_rw.

On 11/14/2018 4:28 AM, Andy Duan wrote:
> From: David Miller <davem@...emloft.net> Sent: 2018年11月11日 8:34
>> [ As I am trying to remove direct SKB list pointer accesses I am
>>   committing this to net-next.  If this causes a lot of grief I
>>   can and will revert, just let me know. ]

[...]

>
> I just have bcm4339 in hands, test the patch on i.MX7D sdb board with bcm4339, it works fine with iperf testing.
>
> Tested-by: Fugang Duan <fugang.duan@....com>

Thanks, Andy

Can you do one more check? Please insert brcmfmac with module parameter 
debug=2 and let me know if the following log message is seen:

brcmfmac: brcmf_sdiod_sgtable_alloc: nents=X

If not seen, the driver does not go through the patched code.

Regards,
Arend