netdev - Re: [PATCH 12/19] usbnet: smsc95xx: Replace ad-hoc PHY functions with generic ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Jan 2019 03:19:47 +0100
From:   Marek Vasut <marex@...x.de>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>,
        Nisar Sayed <Nisar.Sayed@...rochip.com>,
        Woojung Huh <Woojung.Huh@...rochip.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH 12/19] usbnet: smsc95xx: Replace ad-hoc PHY functions with
 generic ones

On 1/3/19 2:28 PM, Andrew Lunn wrote:
> On Thu, Jan 03, 2019 at 02:10:33AM +0100, Marek Vasut wrote:
>> Replace the ad-hoc reimplementation of genphy_soft_reset() and
>> genphy_config_aneg() with the generic functions.
> 
> phylib will either call the phy driver specific reset function, or
> genphy_soft_reset. The same is also true for configuring
> auto-neg. Please just kill this code and leave the PHY driver to do
> its job.

In this patch or subsequent ? I think we should do that in a subsequent
patch, to keep this bisectable in case something breaks.

-- 
Best regards,
Marek Vasut