netdev - Re: [net-next 07/15] net/mlx5e: Use helpers to get headers criteria and value pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALzJLG_awekDuMGNYF-Xnp5Y-iUcUaKLBJdEse2svxoK0OmMpg@mail.gmail.com>
Date:   Fri, 5 Apr 2019 13:41:14 -0700
From:   Saeed Mahameed <saeedm@....mellanox.co.il>
To:     David Miller <davem@...emloft.net>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        Linux Netdev List <netdev@...r.kernel.org>,
        Eli Britstein <elibr@...lanox.com>,
        Roi Dayan <roid@...lanox.com>
Subject: Re: [net-next 07/15] net/mlx5e: Use helpers to get headers criteria
 and value pointers

On Wed, Apr 3, 2019 at 9:52 PM David Miller <davem@...emloft.net> wrote:
>
> From: Saeed Mahameed <saeedm@...lanox.com>
> Date: Tue,  2 Apr 2019 16:03:42 -0700
>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > index 7c1ea0a17024..d3a507be72d4 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
> > @@ -1438,6 +1438,26 @@ static int parse_tunnel_attr(struct mlx5e_priv *priv,
> >       return 0;
> >  }
> >
> > +static inline void *get_match_headers_criteria(u32 flags,
> > +                                            struct mlx5_flow_spec *spec)
> > +{
>
> Do not use the inline keyword in foo.c files, let the compiler decide.

Right, i missed this one, will fix it up. Thanks !