netdev - Re: [PATCH net v2] ipv6: Handle race in addrconf_dad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f896d905-9f69-465f-23c0-7e9a6014d990@gmail.com>
Date:   Wed, 2 Oct 2019 17:36:34 -0700
From:   Eric Dumazet <erdnetdev@...il.com>
To:     David Ahern <dsahern@...il.com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        David Ahern <dsahern@...nel.org>, davem@...emloft.net,
        jakub.kicinski@...ronome.com
Cc:     netdev@...r.kernel.org, rajendra.dendukuri@...adcom.com
Subject: Re: [PATCH net v2] ipv6: Handle race in addrconf_dad_work



On 10/2/19 5:10 PM, David Ahern wrote:
> On 10/2/19 4:36 PM, Eric Dumazet wrote:
>> This might be related to a use of a bonding device, with a mlx4 slave.
>>
> 
> does it only happen with bonds?

All my hosts have bonds, some are just fine with your patch, but others are not.

> 
> bond shows IF_READY even though the underlying device is carrier down
> which seems wrong; if a lower device is not carrier up then DAD does not
> really happen.
> 
> A quick test with a VM (and setting carrier off on the tap) shows that
> with the current patch in place the bond address stays in tentative
> state. Reverting this patch and the tentative flag is removed. DAD never
> happens since carrier is off on the one link in the bond, so the
> tentative flag getting cleared is wrong.
> 
> I need to step out; come back to this later.
> 

Note that in my setup nodad flag is requested.