lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Nov 2019 07:38:55 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <jakub.kicinski@...ronome.com> Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, Daniel Borkmann <daniel@...earbox.net>, Network Development <netdev@...r.kernel.org>, OSS Drivers <oss-drivers@...ronome.com>, bpf <bpf@...r.kernel.org> Subject: Re: [oss-drivers] Re: [PATCH bpf-next] Revert "selftests: bpf: Don't try to read files without read permission" Fri, Nov 01, 2019 at 02:28:35AM CET, jakub.kicinski@...ronome.com wrote: >On Thu, 31 Oct 2019 17:56:46 -0700, Alexei Starovoitov wrote: >> On Thu, Oct 31, 2019 at 5:51 PM Jakub Kicinski >> <jakub.kicinski@...ronome.com> wrote: >> > >> > This reverts commit 5bc60de50dfe ("selftests: bpf: Don't try to read >> > files without read permission"). >> > >> > Quoted commit does not work at all, and was never tested. >> > Script requires root permissions (and tests for them) >> > and os.access() will always return true for root. >> > >> > The correct fix is needed in the bpf tree, so let's just >> > revert and save ourselves the merge conflict. >> > >> > Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com> >> >> Acked-by: Alexei Starovoitov <ast@...nel.org> >> Since original commit is broken may be apply directly to net-next ? >> I'm fine whichever way. > >I'm 3 fixes down to get test_offloads.py to work again. One for >cls_bpf, one for the test itself and one for net/core/dev.c logic. >Should I target all those at net? > >Are you and Daniel running test_offloads.py? It looks like it lots of >things slipped in since I last run it :( > >> I would wait for Jiri to reply first though. > >Not sure what he can contribute at this point but sure :/ I'm okay with Jakub taking care of the fix. Thanks!
Powered by blists - more mailing lists