netdev - Re: [PATCH bpf-next] Revert "selftests: bpf: Don't try to read files without read permission"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ab2db974-9754-1804-caa8-402ad9e8cb50@iogearbox.net>
Date:   Fri, 1 Nov 2019 13:16:33 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        alexei.starovoitov@...il.com
Cc:     netdev@...r.kernel.org, oss-drivers@...ronome.com,
        bpf@...r.kernel.org, jiri@...nulli.us
Subject: Re: [PATCH bpf-next] Revert "selftests: bpf: Don't try to read files
 without read permission"

On 11/1/19 1:51 AM, Jakub Kicinski wrote:
> This reverts commit 5bc60de50dfe ("selftests: bpf: Don't try to read
> files without read permission").
> 
> Quoted commit does not work at all, and was never tested.
> Script requires root permissions (and tests for them)
> and os.access() will always return true for root.
> 
> The correct fix is needed in the bpf tree, so let's just
> revert and save ourselves the merge conflict.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Applied, thanks!