netdev - Re: [PATCH net-next 08/12] net: mscc: ocelot: publish structure definitions to include/soc/mscc/ocelot.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191112144251.GF10875@lunn.ch>
Date:   Tue, 12 Nov 2019 15:42:51 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     jakub.kicinski@...ronome.com, davem@...emloft.net,
        alexandre.belloni@...tlin.com, f.fainelli@...il.com,
        vivien.didelot@...il.com, joergen.andreasen@...rochip.com,
        allan.nielsen@...rochip.com, horatiu.vultur@...rochip.com,
        claudiu.manoil@....com, netdev@...r.kernel.org,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH net-next 08/12] net: mscc: ocelot: publish structure
 definitions to include/soc/mscc/ocelot.h

> diff --git a/include/soc/mscc/ocelot.h b/include/soc/mscc/ocelot.h

..

> +#else
> +
> +/* I/O */
> +u32 ocelot_port_readl(struct ocelot_port *port, u32 reg)
> +{
> +	return 0;
> +}

These stubs are for when the core is missing? I don't think that makes
sense. What use is a DSA or switchdev driver without the core? I would
put in a hard dependency in the Kconfig, so the DSA driver can only be
built when the core is available, and skip these stubs.

      Andrew