lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 24 Mar 2020 16:16:54 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Marek Vasut <marex@...x.de>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org
Subject: Re: [PATCH 13/14] net: ks8851: Implement Parallel bus operations

Hi Marek,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[also build test ERROR on net-next/master linus/master ipvs/master v5.6-rc7 next-20200323]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Marek-Vasut/net-ks8851-Unify-KS8851-SPI-and-MLL-drivers/20200324-074805
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 6cd6cbf593bfa3ae6fc3ed34ac21da4d35045425
config: x86_64-kexec (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   ld: drivers/net/ethernet/micrel/ks8851.o: in function `ks8851_set_eeprom':
>> drivers/net/ethernet/micrel/ks8851.c:875: undefined reference to `eeprom_93cx6_wren'
>> ld: drivers/net/ethernet/micrel/ks8851.c:880: undefined reference to `eeprom_93cx6_read'
>> ld: drivers/net/ethernet/micrel/ks8851.c:890: undefined reference to `eeprom_93cx6_write'
>> ld: drivers/net/ethernet/micrel/ks8851.c:891: undefined reference to `eeprom_93cx6_wren'
   ld: drivers/net/ethernet/micrel/ks8851.o: in function `ks8851_get_eeprom':
>> drivers/net/ethernet/micrel/ks8851.c:914: undefined reference to `eeprom_93cx6_multiread'

vim +875 drivers/net/ethernet/micrel/ks8851.c

51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  856  
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  857  static int ks8851_set_eeprom(struct net_device *dev,
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  858  			     struct ethtool_eeprom *ee, u8 *data)
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  859  {
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  860  	struct ks8851_net *ks = netdev_priv(dev);
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  861  	int offset = ee->offset;
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  862  	int len = ee->len;
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  863  	u16 tmp;
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  864  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  865  	/* currently only support byte writing */
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  866  	if (len != 1)
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  867  		return -EINVAL;
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  868  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  869  	if (ee->magic != KS_EEPROM_MAGIC)
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  870  		return -EINVAL;
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  871  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  872  	if (ks8851_eeprom_claim(ks))
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  873  		return -ENOENT;
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  874  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21 @875  	eeprom_93cx6_wren(&ks->eeprom, true);
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  876  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  877  	/* ethtool currently only supports writing bytes, which means
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  878  	 * we have to read/modify/write our 16bit EEPROMs */
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  879  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21 @880  	eeprom_93cx6_read(&ks->eeprom, offset/2, &tmp);
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  881  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  882  	if (offset & 1) {
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  883  		tmp &= 0xff;
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  884  		tmp |= *data << 8;
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  885  	} else {
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  886  		tmp &= 0xff00;
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  887  		tmp |= *data;
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  888  	}
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  889  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21 @890  	eeprom_93cx6_write(&ks->eeprom, offset/2, tmp);
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21 @891  	eeprom_93cx6_wren(&ks->eeprom, false);
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  892  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  893  	ks8851_eeprom_release(ks);
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  894  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  895  	return 0;
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  896  }
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  897  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  898  static int ks8851_get_eeprom(struct net_device *dev,
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  899  			     struct ethtool_eeprom *ee, u8 *data)
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  900  {
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  901  	struct ks8851_net *ks = netdev_priv(dev);
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  902  	int offset = ee->offset;
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  903  	int len = ee->len;
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  904  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  905  	/* must be 2 byte aligned */
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  906  	if (len & 1 || offset & 1)
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  907  		return -EINVAL;
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  908  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  909  	if (ks8851_eeprom_claim(ks))
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  910  		return -ENOENT;
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  911  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  912  	ee->magic = KS_EEPROM_MAGIC;
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  913  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21 @914  	eeprom_93cx6_multiread(&ks->eeprom, offset/2, (__le16 *)data, len/2);
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  915  	ks8851_eeprom_release(ks);
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  916  
51b7b1c34e1958 drivers/net/ethernet/micrel/ks8851.c Ben Dooks     2011-11-21  917  	return 0;
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  918  }
a84afa40e07b68 drivers/net/ks8851.c                 Sebastien Jan 2010-05-05  919  

:::::: The code at line 875 was first introduced by commit
:::::: 51b7b1c34e195886e38ee93ff2a8a203745f897f KSZ8851-SNL: Add ethtool support for EEPROM via eeprom_93cx6

:::::: TO: Ben Dooks <ben@...tec.co.uk>
:::::: CC: David S. Miller <davem@...emloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (27775 bytes)

Powered by blists - more mailing lists