lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Mar 2020 11:41:02 +0100 From: Lukas Wunner <lukas@...ner.de> To: Marek Vasut <marex@...x.de> Cc: netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>, Petr Stetiar <ynezz@...e.cz>, YueHaibing <yuehaibing@...wei.com>, Andrew Lunn <andrew@...n.ch> Subject: Re: [PATCH 08/14] net: ks8851: Use 16-bit read of RXFC register On Tue, Mar 24, 2020 at 12:42:57AM +0100, Marek Vasut wrote: > The RXFC register is the only one being read using 8-bit accessors. > To make it easier to support the 16-bit accesses used by the parallel > bus variant of KS8851, use 16-bit accessor to read RXFC register as > well as neighboring RXFCTR register. This means that an additional 8 bits need to be transferred over the SPI bus whenever a set of packets is read from the RX queue. This should be avoided. I'd suggest adding a separate hook to read RXFC and thus keep the 8-bit read function for the SPI variant. Thanks, Lukas
Powered by blists - more mailing lists