netdev - Re: [PATCH V2 ethtool] ethtool: Add support for Low Latency Reed Solomon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200324145415.GQ31519@unicorn.suse.cz>
Date:   Tue, 24 Mar 2020 15:54:15 +0100
From:   Michal Kubecek <mkubecek@...e.cz>
To:     Tariq Toukan <tariqt@...lanox.com>
Cc:     "John W . Linville" <linville@...driver.com>,
        netdev@...r.kernel.org, Aya Levin <ayal@...lanox.com>,
        Eran Ben Elisha <eranbe@...lanox.com>
Subject: Re: [PATCH V2 ethtool] ethtool: Add support for Low Latency Reed
 Solomon

On Tue, Mar 24, 2020 at 04:01:41PM +0200, Tariq Toukan wrote:
> From: Aya Levin <ayal@...lanox.com>
> 
> Introduce a new FEC mode LL-RS: Low Latency Reed Solomon, update print
> and initialization functions accordingly. In addition, update related
> man page.
> 
> Signed-off-by: Aya Levin <ayal@...lanox.com>
> Reviewed-by: Eran Ben Elisha <eranbe@...lanox.com>
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> ---
[...]
> @@ -754,6 +755,12 @@ static void dump_link_caps(const char *prefix, const char *an_prefix,
>  			fprintf(stdout, " RS");
>  			fecreported = 1;
>  		}
> +		if (ethtool_link_mode_test_bit(ETHTOOL_LINK_MODE_FEC_LLRS_BIT,
> +					       mask)) {
> +			fprintf(stdout, " LL-RS");
> +			fecreported = 1;
> +		}
> +
>  		if (!fecreported)
>  			fprintf(stdout, " Not reported");
>  		fprintf(stdout, "\n");

Kernel uses "LLRS" for this bit since commit f623e5970501 ("ethtool: Add
support for low latency RS FEC") so if you use "LL-RS" here, the output
will differ between ioctl and netlink code paths.

It's not necessary to use the same name also for --show-fec/--set-fec
(string set and netlink support for these is still work in progress) but
it would IMHO be better to be consistent.

Michal Kubecek