netdev - Re: NET: r8168/r8169 identifying fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200413113430.GM334007@unreal>
Date:   Mon, 13 Apr 2020 14:34:30 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Lauri Jakku <ljakku77@...il.com>
Cc:     netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
        nic_swsd@...ltek.com
Subject: Re: NET: r8168/r8169 identifying fix

On Mon, Apr 13, 2020 at 02:02:01PM +0300, Lauri Jakku wrote:
> Hi,
>
> Comments inline.
>
> On 2020-04-13 13:58, Leon Romanovsky wrote:
> > On Mon, Apr 13, 2020 at 01:30:13PM +0300, Lauri Jakku wrote:
> >> From 2d41edd4e6455187094f3a13d58c46eeee35aa31 Mon Sep 17 00:00:00 2001
> >> From: Lauri Jakku <lja@....fi>
> >> Date: Mon, 13 Apr 2020 13:18:35 +0300
> >> Subject: [PATCH] NET: r8168/r8169 identifying fix
> >>
> >> The driver installation determination made properly by
> >> checking PHY vs DRIVER id's.
> >> ---
> >>  drivers/net/ethernet/realtek/r8169_main.c | 70 ++++++++++++++++++++---
> >>  drivers/net/phy/mdio_bus.c                | 11 +++-
> >>  2 files changed, 72 insertions(+), 9 deletions(-)
> >
> > I would say that most of the code is debug prints.
> >
>
> I tought that they are helpful to keep, they are using the debug calls, so
> they are not visible if user does not like those.

You are missing the point of who are your users.

Users want to have working device and the code. They don't need or like
to debug their kernel.

Thanks