netdev - Re: netif_device_present() and Runtime PM / PCI D3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200531150504.GB897737@lunn.ch>
Date:   Sun, 31 May 2020 17:05:04 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>
Subject: Re: netif_device_present() and Runtime PM / PCI D3

On Sun, May 31, 2020 at 02:07:46PM +0200, Heiner Kallweit wrote:
> I just wonder about the semantics of netif_device_present().
> If a device is in PCI D3 (e.g. being runtime-suspended), then it's
> not accessible. So is it present or not?
> The description of the function just mentions the obvious case that
> the device has been removed from the system.

Hi Heiner

Looking at the code, there is no directly link to runtime suspend.  If
the drivers suspend code has detached the device then it won't be
present, but that tends to be not runtime PM, but WOL etc.

> Related is the following regarding ethtool:
> dev_ethtool() returns an error if device isn't marked as present.
> If device is runtime-suspended and in PCI D3, then the driver
> may still be able to provide quite some (cached) info about the
> device. Same applies for settings: Even if device is sleeping,
> the driver may store new settings and apply them once the device
> is awake again.

I think playing with cached state of a device is going to be a sources
of hard to find bugs. I would want to see a compelling use case for
this.

	Andrew