netdev - Re: [PATCH net-next] cls_flower: remove mpls_opts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200601.120125.700408609849004774.davem@davemloft.net>
Date:   Mon, 01 Jun 2020 12:01:25 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gnault@...hat.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org, jhs@...atatu.com,
        xiyou.wangcong@...il.com, jiri@...nulli.us
Subject: Re: [PATCH net-next] cls_flower: remove mpls_opts_policy

From: Guillaume Nault <gnault@...hat.com>
Date: Sat, 30 May 2020 20:49:56 +0200

> Compiling with W=1 gives the following warning:
> net/sched/cls_flower.c:731:1: warning: ‘mpls_opts_policy’ defined but not used [-Wunused-const-variable=]
> 
> The TCA_FLOWER_KEY_MPLS_OPTS contains a list of
> TCA_FLOWER_KEY_MPLS_OPTS_LSE. Therefore, the attributes all have the
> same type and we can't parse the list with nla_parse*() and have the
> attributes validated automatically using an nla_policy.
> 
> fl_set_key_mpls_opts() properly verifies that all attributes in the
> list are TCA_FLOWER_KEY_MPLS_OPTS_LSE. Then fl_set_key_mpls_lse()
> uses nla_parse_nested() on all these attributes, thus verifying that
> they have the NLA_F_NESTED flag. So we can safely drop the
> mpls_opts_policy.
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Guillaume Nault <gnault@...hat.com>

Applied, thank you.